Skip to content

fix-iar-include-typo #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 21, 2025
Merged

fix-iar-include-typo #463

merged 11 commits into from
Sep 21, 2025

Conversation

@ericminnerath
Copy link
Contributor

@ericminnerath ericminnerath commented Aug 27, 2025 •
edited
Loading

PR checklist

  • Updated function header with a short description and version number
  • Added test case for bug fix or new feature
  • Validated on real hardware

fdesbiens and others added 11 commits July 17, 2025 16:26
@fdesbiens
Added workflow permissions.
b19b468 
Signed-off-by: Frédéric Desbiens <frederic.desbiens@eclipse-foundation.org>
@fdesbiens
Merge pull request eclipse-threadx#453 from eclipse-threadx/ci-fixes
171af05 
Added workflow permissions.
@fdesbiens
Updated all actions to their latest release.
754c348 
Signed-off-by: Frédéric Desbiens <frederic.desbiens@eclipse-foundation.org>
@fdesbiens
Merge pull request eclipse-threadx#454 from eclipse-threadx/ci-fixes
acf2e57 
Updated all actions to their latest release.
@fdesbiens
Fixed code coverage artefacts upload
c00056b
@fdesbiens
Merge pull request eclipse-threadx#455 from eclipse-threadx/ci-fixes
48c173c 
Fixed code coverage artefacts upload
@fdesbiens
Added condition to "Coverage Report Name". Corrected formatting.
8e808e7
@fdesbiens
Merge pull request eclipse-threadx#456 from eclipse-threadx/ci-fixes-2
1e109f0 
Added condition to "Coverage Report Name". Corrected formatting.
@fdesbiens
Fixed code coverage report download step in deploy_code_coverage.
8616486
@fdesbiens
Merge pull request eclipse-threadx#457 from eclipse-threadx/ci-fixes-2
12dac1d 
Fixed code coverage report download step in deploy_code_coverage.
@ericminnerath
initial commit
67e4156
@ericminnerath
Copy link
Contributor Author

Fixes #462

@ericminnerath
Copy link
Contributor Author

When building on Windows 10, Windows 11, and Linux on iAR EWARM v9.60.4, no longer getting the following build error:
threadx/ports/cortex_m33/iar/src/tx_iar.c(442) : Fatal Error[Pe1696]: cannot open source file "DLib_threads.h"

@ericminnerath ericminnerath marked this pull request as ready for review August 27, 2025 22:19
@fdesbiens fdesbiens changed the base branch from master to dev September 2, 2025 15:02
@ericminnerath
Copy link
Contributor Author

@fdesbiens are there any blockers I need to do for this PR?

@fdesbiens fdesbiens merged commit ca7589c into eclipse-threadx:dev Sep 21, 2025
7 of 9 checks passed
@fdesbiens
Copy link
Contributor

Hi @ericminnerath.

No. All good. I just merged to the dev branch. We will merge dev in master for our next release. This should happen in the next few weeks.

@ericminnerath
Copy link
Contributor Author

@fdesbiens thanks. Just to close the loop, can you point me to the documentation that suggests PR should get targeted to "dev" branch?

@fdesbiens
Copy link
Contributor

Hi @ericminnerath.

This is a fairly new practice we did not communicate publicaly about yet. My apologies. We will update the README and CONTRIBUTING with proeminent notices to that effect.

@ericminnerath ericminnerath deleted the fix-iar-include branch September 21, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericminnerath @fdesbiens